refactor: force ipv4 localhost #22394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing "localhost" with "127.0.0.1" in the codebase; sometimes the name localhost force-resolves to ipv6
0xsirsaif
requested review from
a team and
surajshetty3416
and removed request for
a team
ankush
added
the
Run UI Tests
ankush
approved these changes
Sep 13, 2023
Change not required.
ankush
removed
the
Run UI Tests
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
* reafctor: force ipv4 localhost Replacing "localhost" with "127.0.0.1" in the codebase; sometimes the name localhost force-resolves to ipv6 * revert: leave localhost usage in oauth tests Change not required. --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit aa7ee1c)
ankush
pushed a commit
that referenced
this pull request
Sep 13, 2023
* reafctor: force ipv4 localhost Replacing "localhost" with "127.0.0.1" in the codebase; sometimes the name localhost force-resolves to ipv6 * revert: leave localhost usage in oauth tests Change not required. --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit aa7ee1c) Co-authored-by: 0xsaif <muhamed.e.saif@gmail.com>
sagarvora
reviewed
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
localhostwith127.0.0.1in the codebase; sometimes the name localhost force-resolves to ipv6