-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't encode /
in html escaping
#22871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't really required and `/` is used in user facing text.
ankush
requested review from
a team and
shariquerik
and removed request for
a team
October 23, 2023 10:15
ankush
added
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
Backport the PR to v15
labels
Oct 23, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
This isn't really required and `/` is used in user facing text. (cherry picked from commit 9abb964)
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
This isn't really required and `/` is used in user facing text. (cherry picked from commit 9abb964)
This was referenced Oct 23, 2023
ankush
added a commit
that referenced
this pull request
Oct 23, 2023
This isn't really required and `/` is used in user facing text. (cherry picked from commit 9abb964) Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush
added a commit
that referenced
this pull request
Oct 23, 2023
This isn't really required and `/` is used in user facing text. (cherry picked from commit 9abb964) Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
# [14.53.0](v14.52.2...v14.53.0) (2023-10-24) ### Bug Fixes * allow hiding/unhiding others private workspace if you are workspace manager ([89ebb9d](89ebb9d)) * amount calculation issue ([#22820](#22820)) ([484f184](484f184)) * Check perms before sharing linked docs ([#22783](#22783)) ([#22786](#22786)) ([729d842](729d842)) * check read before assigning/removing ([#22779](#22779)) ([#22785](#22785)) ([61056c1](61056c1)) * compare with content value for Link fieldtypes ([de6d271](de6d271)) * cron job firing immediately after save (backport [#22795](#22795)) ([#22806](#22806)) ([f7c43e1](f7c43e1)) * do not allow creating private workspace for other users ([caa28b8](caa28b8)) * do not allow deleting other's private workspaces ([745b79c](745b79c)) * do not allow editing other's private workspaces ([11dd3a7](11dd3a7)) * don't encode `/` in html escaping ([#22871](#22871)) ([#22874](#22874)) ([4ce39ec](4ce39ec)) * escape print format code field([#22852](#22852)) ([#22865](#22865)) ([ba226fb](ba226fb)) * filename xss ([#22778](#22778)) ([#22782](#22782)) ([87aa9e6](87aa9e6)) * ignore duplicate perm check on assign hooks (backport [#22832](#22832)) ([#22833](#22833)) ([a258d84](a258d84)) * number card shorten number is not formatted correctly if number format is not default ([5f23775](5f23775)) * resolve page not found error ([4563b86](4563b86)) ### Features * rate limit logins based on IP too (backport [#22774](#22774)) ([#22780](#22780)) ([de27391](de27391))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
## [15.0.2](v15.0.1...v15.0.2) (2023-10-31) ### Bug Fixes * Add translation to "Not Saved" state in print format builder ([#22920](#22920)) ([#22995](#22995)) ([8e8274e](8e8274e)) * developer mode in website theme ([#22958](#22958)) ([#22998](#22998)) ([138e679](138e679)) * don't encode `/` in html escaping ([#22871](#22871)) ([#22875](#22875)) ([2e456f8](2e456f8)) * escape print format code field([#22852](#22852)) ([#22866](#22866)) ([82d8809](82d8809)) * font loading on custom website theme (backport [#22967](#22967)) ([#22992](#22992)) ([3984214](3984214)) * Footer should show up once at end if not repeating header/footer ([#22902](#22902)) ([#22910](#22910)) ([e7ce38a](e7ce38a)) * group by didn't work for the frappe.client.get_value ([#22969](#22969)) ([#22973](#22973)) ([773b74f](773b74f)) * ignore stale custom fields while checking back-links ([#22940](#22940)) ([#22943](#22943)) ([7ce96d9](7ce96d9)) * ignore workspace links on delete ([#22895](#22895)) ([#22897](#22897)) ([821d1e9](821d1e9)) * improve label and description for `fetch_if_empty` ([9e690be](9e690be)) * list view formatting logic (backport [#22646](#22646)) ([#22849](#22849)) ([16363ab](16363ab)) * **migrate:** raise exception even if db is not available ([#22922](#22922)) ([#23000](#23000)) ([a02ba82](a02ba82)) * **minor:** hide grid row on modal close ([#22930](#22930)) ([#22932](#22932)) ([c5a9fdf](c5a9fdf)) * **minor:** use inline-flex in page-actions btn ([#22846](#22846)) ([#22868](#22868)) ([59114ef](59114ef)) * resolve page not found error ([fc9b644](fc9b644)) * revert to setting `frappe.dynamic_link` instead of using `cur_frm` ([37243c6](37243c6)) * revert unintentional quick entry default for Address ([#22974](#22974)) ([f7aaaf3](f7aaaf3)) * skip invalid numbers on SMS `receiver_list` (backport [#22879](#22879)) ([#23003](#23003)) ([5b905e3](5b905e3)) * use frm.set_value for updating fields ([#22860](#22860)) ([#22869](#22869)) ([1df1a27](1df1a27)) * web styles espresso (backport [#22924](#22924)) ([#22933](#22933)) ([b2c6f07](b2c6f07)) ### Performance Improvements * query fields only once ([#22982](#22982)) ([#22988](#22988)) ([7e2adb4](7e2adb4))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't really required and
/
is used in user facing text.