Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minor): mobile menu & sidebar attachment text #23013

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

maharshivpatel
Copy link
Collaborator

  • Added Mobile Menu to be left Aligned until SM Breakpoint.
  • Attachment Text in Sidebar is now smaller to match the rest of the text
  • fixed close icon aligned in form tags that broken by .btn padding

Navbar on different breakpoints

Screen.Recording.2023-10-31.at.1.33.19.PM.mov

Sidebar Text and form tags

Screenshot 2023-10-31 at 1 37 37 PM

- Mobile Menu have Text left Aligned until SM Breakpoint
- Attachement Text in Sidebar is now smaller to match the rest of the text
- fixed close icon aligned in form tags that broken by btn padding
@maharshivpatel maharshivpatel requested review from a team and ankush and removed request for a team October 31, 2023 08:11
@maharshivpatel maharshivpatel added the backport version-15-hotfix Backport the PR to v15 label Oct 31, 2023
@maharshivpatel
Copy link
Collaborator Author

flaky not related. merging

@maharshivpatel maharshivpatel merged commit 8d7eac3 into frappe:develop Oct 31, 2023
22 of 24 checks passed
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
- Added Mobile Menu to be left Aligned until SM Breakpoint.
- Attachment Text in Sidebar is now smaller to match the rest of the text
- fixed close icon aligned in form tags that broken by .btn padding

(cherry picked from commit 8d7eac3)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant