fix(WebForm): Replace get_cached_value with get_value
#23302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
ankush
reviewed
Nov 20, 2023
frappe.get_cached_value does not support filters
cogk
force-pushed
the
fix-webform-get-cached-value
branch
from
4ef639d
to
8b03a48
Compare
ankush
approved these changes
Nov 20, 2023
ankush
added a commit
that referenced
this pull request
Nov 20, 2023
…-23302 fix(WebForm): Replace `get_cached_value` with `get_value` (backport #23302)
This was referenced Nov 20, 2023
|
Closes #23284 |
akhilnarang
added a commit
that referenced
this pull request
Nov 22, 2023
…-23302 fix(WebForm): Replace `get_cached_value` with `get_value` (backport #23302)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that
frappe.get_cached_value(values cached in Redis) does not support filters, so revert back toget_value(queries the DB, optional in-memory/request cache).frappe/frappe/__init__.py
Lines 1183 to 1185 in d715b0a
This might mean that unit tests are not covering this case (DocType without show_title_field_in_link).