Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:The title of the Link control does not appear correctly in the we… #23270

Merged
merged 5 commits into from
Nov 18, 2023
Merged

fix:The title of the Link control does not appear correctly in the we… #23270

merged 5 commits into from
Nov 18, 2023

Conversation

Nrtyck
Copy link
Contributor

@Nrtyck Nrtyck commented Nov 18, 2023

The title of the Link control does not appear correctly in the website form

@Nrtyck
fix:The title of the Link control does not appear correctly in the we…
f095c9e 
…bsite form

The title of the Link control does not appear correctly in the website form
@Nrtyck Nrtyck requested review from a team and shariquerik and removed request for a team November 18, 2023 11:07
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Nov 18, 2023
@shariquerik shariquerik self-assigned this Nov 18, 2023
@Nrtyck @shariquerik
Update frappe/website/doctype/web_form/web_form.py
76cb096 
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
@shariquerik
Copy link
Member

@Nrtyck
Note for future contributions: try to follow the semantic commit to avoid CI failure

@shariquerik shariquerik added the backport version-15-hotfix Backport the PR to v15 label Nov 18, 2023
@shariquerik shariquerik merged commit f27f570 into frappe:version-15-hotfix Nov 18, 2023
17 of 18 checks passed
@shariquerik shariquerik added backport develop port port to develop branch and removed backport version-15-hotfix Backport the PR to v15 labels Nov 18, 2023
mergify bot pushed a commit that referenced this pull request Nov 18, 2023
@Nrtyck @mergify
fix:The title of the Link control does not appear correctly in the we… (
cf565c8 
#23270)

(cherry picked from commit f27f570)
@mergify mergify bot mentioned this pull request Nov 18, 2023
Merged
shariquerik pushed a commit that referenced this pull request Nov 18, 2023
@mergify @Nrtyck
fix:The title of the Link control does not appear correctly in the we…
318b2e5 
…… (backport #23270) (#23280)

Co-authored-by: Nrtyck <37080373+Nrtyck@users.noreply.github.com>
@cogk cogk mentioned this pull request Nov 20, 2023
Merged
@akhilnarang akhilnarang added the backport version-14-hotfix backport to version 14 label Nov 22, 2023
mergify bot pushed a commit that referenced this pull request Nov 22, 2023
@Nrtyck @mergify
fix:The title of the Link control does not appear correctly in the we… (
f58bbcf 
#23270)

(cherry picked from commit f27f570)
@mergify mergify bot mentioned this pull request Nov 22, 2023
Merged
akhilnarang added a commit that referenced this pull request Nov 22, 2023
@akhilnarang
Merge pull request #23340 from frappe/mergify/bp/version-14-hotfix/pr…
4e5e763 
…-23270

fix:The title of the Link control does not appear correctly in the we… (backport #23270)
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shariquerik shariquerik shariquerik requested changes

Assignees

@shariquerik shariquerik

Labels
add-test-cases Add test case to validate fix or enhancement backport develop port port to develop branch backport version-14-hotfix backport to version 14 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Nrtyck @shariquerik @frappe-pr-bot @akhilnarang