fix: honour max file size in upload file #23333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case path is /api/method/upload_file, we should honour the max file size set in system settings and set request max_content_length to that value.
maharshivpatel
requested review from
a team and
ankush
and removed request for
a team
github-actions
bot
added
the
add-test-cases
maharshivpatel
added
backport version-14-hotfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #23333 +/- ##
===========================================
- Coverage 62.27% 62.24% -0.04%
===========================================
Files 771 771
Lines 73821 73891 +70
Branches 6342 6342
===========================================
+ Hits 45975 45996 +21
- Misses 24237 24286 +49
Partials 3609 3609
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Nov 22, 2023
ankush
added a commit
that referenced
this pull request
Nov 22, 2023
…-23333 fix: honour max file size in upload file (backport #23333)
ankush
added a commit
that referenced
this pull request
Nov 22, 2023
…-23333 fix: honour max file size in upload file (backport #23333)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case path is /api/method/upload_file, we should honour the max file size set in system settings and set request max_content_length to that value.