Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honour max file size in upload file (backport #23333) #23339

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 22, 2023

This is an automatic backport of pull request #23333 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

maharshivpatel and others added 2 commits November 22, 2023 05:27
In case path is /api/method/upload_file, we should honour the max file size
set in system settings and set request max_content_length to that value.

(cherry picked from commit 5af9b29)
(cherry picked from commit 28d05c4)
@mergify mergify bot requested review from a team and shariquerik and removed request for a team November 22, 2023 05:27
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Nov 22, 2023
@ankush ankush merged commit 695571d into version-15-hotfix Nov 22, 2023
16 of 19 checks passed
@ankush ankush deleted the mergify/bp/version-15-hotfix/pr-23333 branch November 22, 2023 05:30
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants