Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set default for search result limit if empty #24713

Merged
merged 1 commit into from
Feb 3, 2024
Merged

fix: Set default for search result limit if empty #24713

merged 1 commit into from
Feb 3, 2024

Conversation

ankush
Copy link
Member

@ankush ankush commented Feb 3, 2024 •
edited

This isn't really required but edge case like this can happen:

  • Site created but setup not completed
  • Site is now updated
  • Now default is not set for new field, so None gets propagated.
  File "apps/frappe/frappe/desk/page/setup_wizard/setup_wizard.py", line 63, in setup_complete
    return process_setup_stages(stages, args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/desk/page/setup_wizard/setup_wizard.py", line 83, in process_setup_stages
    task.get("fn")(task.get("args"))
  File "apps/frappe/frappe/desk/page/setup_wizard/setup_wizard.py", line 112, in update_global_settings
    update_system_settings(args)
  File "apps/frappe/frappe/desk/page/setup_wizard/setup_wizard.py", line 191, in update_system_settings
    system_settings.save()
  File "apps/frappe/frappe/model/document.py", line 334, in save
    return self._save(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 370, in _save
    self.run_before_save_methods()
  File "apps/frappe/frappe/model/document.py", line 1085, in run_before_save_methods
    self.run_method("validate")
  File "apps/frappe/frappe/model/document.py", line 954, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 1320, in composer
    return composed(self, method, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 1302, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
                              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/model/document.py", line 951, in fn
    return method_object(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "apps/frappe/frappe/core/doctype/system_settings/system_settings.py", line 135, in validate
    if self.link_field_results_limit > 50:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '>' not supported between instances of 'NoneType' and 'int'

@ankush ankush requested review from a team and surajshetty3416 and removed request for a team February 3, 2024 07:02
@ankush ankush added the backport version-15-hotfix Backport the PR to v15 label Feb 3, 2024
@ankush ankush enabled auto-merge (squash) February 3, 2024 07:07
@ankush ankush merged commit 25692a3 into frappe:develop Feb 3, 2024
24 checks passed
@ankush ankush deleted the link_field_default branch February 3, 2024 07:18
mergify bot pushed a commit that referenced this pull request Feb 3, 2024
@ankush @mergify
fix: Set default for search result limit if empty (#24713)
8b00460 
(cherry picked from commit 25692a3)
@mergify mergify bot mentioned this pull request Feb 3, 2024
Merged
ankush added a commit that referenced this pull request Feb 3, 2024
@mergify @ankush
fix: Set default for search result limit if empty (#24713) (#24715)
474feb8 
(cherry picked from commit 25692a3)

Co-authored-by: Ankush Menat <ankush@frappe.io>
@barredterra barredterra mentioned this pull request Feb 5, 2024
Closed
frappe-pr-bot pushed a commit that referenced this pull request Feb 6, 2024
@frappe-bot
chore(release): Bumped to Version 15.13.0
82d723b 
# [15.13.0](v15.12.0...v15.13.0) (2024-02-06)

### Bug Fixes

* Allow int fields to be unique ([#24750](#24750)) ([#24756](#24756)) ([6c5ea2f](6c5ea2f))
* Avoid enqueueing during install ([#24679](#24679)) ([#24682](#24682)) ([7825a72](7825a72))
* Check if header/footer html exists before trying to extract ([03fc5b1](03fc5b1))
* check is_translatable link ([#24739](#24739)) ([#24747](#24747)) ([e21e2ca](e21e2ca))
* clear sitemap cache periodically ([#24676](#24676)) ([282e0e6](282e0e6))
* console import progress off-by-one ([#24777](#24777)) ([#24787](#24787)) ([e6ad6e8](e6ad6e8))
* Custom Script runs twice ([5d7d7f7](5d7d7f7))
* Dashboard view realtime error ([#24698](#24698)) ([#24699](#24699)) ([a2a766b](a2a766b))
* data import table UI fix ([064aca2](064aca2))
* date format & pre commit test ([9726c46](9726c46))
* depends on ([9777fe3](9777fe3))
* description ([fe7ed4b](fe7ed4b))
* Disappearing letterhead header in pdf ([e932958](e932958))
* do not allow to set if_owner & report perm together ([290b7e8](290b7e8))
* don't notify links if not public ([019c223](019c223))
* enable syntax highlighting for `PythonExpression` code fields ([#24669](#24669)) ([#24671](#24671)) ([4bbfaa7](4bbfaa7))
* Enqueue deletion of dynamic link after comitting ([#24675](#24675)) ([9fbe981](9fbe981))
* Extract header/footer html into `content` to simplify things ([64102a7](64102a7))
* formatting ([05a6ad8](05a6ad8))
* formatting ([5ba9be8](5ba9be8))
* hide number counter for new document view shortcut ([bb46d23](bb46d23))
* **js:** Handle hidden virtual fields ([#24405](#24405)) ([#24692](#24692)) ([ea82c81](ea82c81))
* **login:** Escape translated strings ([#24431](#24431)) ([#24701](#24701)) ([73c66ce](73c66ce))
* lower default retention periods ([#24697](#24697)) ([#24705](#24705)) ([a155f9e](a155f9e))
* make rate_limiter respect multitenancy ([#24634](#24634)) ([d25bfd9](d25bfd9))
* Make sure sitemap respects robot_txt ([10b583b](10b583b))
* never show virtual fields in list view (backport [#24666](#24666)) ([#24668](#24668)) ([45e2683](45e2683))
* no of rows displayed based on report type ([db4d36f](db4d36f))
* outgoing email account handlng (backport [#24656](#24656)) ([#24657](#24657)) ([4a59a01](4a59a01))
* redirect and open new doctype dialog if route to /doctype/new ([fec821a](fec821a))
* Retry contact update if it fails due to conflict ([#24654](#24654)) ([#24655](#24655)) ([22aa5d3](22aa5d3))
* Set default for search result limit if empty ([#24713](#24713)) ([#24715](#24715)) ([474feb8](474feb8))
* short circuit private files perm check ([e6d7ffe](e6d7ffe))
* show folders in Google Drive Picker ([0d99ef8](0d99ef8)), closes [#23096](#23096)
* Show proper error message for prepared report failure ([#24733](#24733)) ([#24737](#24737)) ([99676af](99676af))
* Skip fulltext indexes during sync ([#24728](#24728)) ([#24734](#24734)) ([8e078f3](8e078f3))
* suggestion ([63764a9](63764a9))
* title link check ([#24731](#24731)) ([#24735](#24735)) ([5c006cd](5c006cd))
* Translate Letterhead information string ([8dfa972](8dfa972))
* typeerror in onboarding_tours.js ([5ae79be](5ae79be))
* Use `TEXT` type for Webhook URLs to support large URLs ([#24763](#24763)) ([f31a3ce](f31a3ce))
* **UX:** improve server script message ([#24770](#24770)) ([5d88275](5d88275))
* virtual fields are never writable ([#24693](#24693)) ([#24696](#24696)) ([d020771](d020771))
* **website:** Handle virtual DocTypes webview routing ([#24445](#24445)) ([#24743](#24743)) ([bed66ca](bed66ca))

### Features

* allow extending site config with a hook ([ffed7bf](ffed7bf))
* Letterhead scripts ([9b296cd](9b296cd))
* **recorder:** profiling and granular recording (backport [#24683](#24683)) ([#24742](#24742)) ([fd04617](fd04617))
* show doctype description on list title hover (backport [#24612](#24612)) ([#24769](#24769)) ([5a0e20b](5a0e20b))
* show doctype description on workspace link hover ([#24598](#24598)) ([#24789](#24789)) ([6107338](6107338))
* use_first_day_of_period ([1fcb105](1fcb105))

### Performance Improvements

* optional faster perm check for files ([3e4a344](3e4a344))
@barredterra barredterra mentioned this pull request Feb 12, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

Assignees
No one assigned
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ankush