feat: let users unlock stuck documents #24782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks older than 12 hours are most likely from dead processes. They can be (mostly) safely ignored.
ankush
requested review from
a team and
surajshetty3416
and removed request for
a team
ankush
force-pushed
the
file_locking_changes
branch
2 times, most recently
from
1c16c39
to
625149c
Compare
ankush
force-pushed
the
file_locking_changes
branch
from
625149c
to
d89e0e7
Compare
akhilnarang
requested changes
Feb 6, 2024
ankush
force-pushed
the
file_locking_changes
branch
2 times, most recently
from
7f7b928
to
f0a53dd
Compare
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
ankush
force-pushed
the
file_locking_changes
branch
from
f0a53dd
to
2c19e84
Compare
akhilnarang
approved these changes
Feb 6, 2024
ankush
added a commit
to frappe/erpnext
that referenced
this pull request
Feb 6, 2024
args are now flat, no need to accept them as dict ref: frappe/frappe#24782
ankush
added a commit
to ankush/hrms
that referenced
this pull request
Feb 6, 2024
We accept flat argument instead of `args` now. Ref: frappe/frappe#24782
ankush
added a commit
to frappe/erpnext
that referenced
this pull request
Feb 6, 2024
args are now flat, no need to accept them as dict ref: frappe/frappe#24782
ankush
added a commit
to ankush/hrms
that referenced
this pull request
Feb 6, 2024
We accept flat argument instead of `args` now. Ref: frappe/frappe#24782
ruchamahabal
pushed a commit
to frappe/hrms
that referenced
this pull request
Feb 6, 2024
We accept flat argument instead of `args` now. Ref: frappe/frappe#24782
mergify bot
pushed a commit
to frappe/hrms
that referenced
this pull request
Feb 6, 2024
We accept flat argument instead of `args` now. Ref: frappe/frappe#24782 (cherry picked from commit 80e6193)
mergify bot
pushed a commit
to frappe/hrms
that referenced
this pull request
Feb 6, 2024
We accept flat argument instead of `args` now. Ref: frappe/frappe#24782 (cherry picked from commit 80e6193) # Conflicts: # hrms/hr/doctype/interview/interview.py
ankush
added
backport version-14-hotfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frappe.throwPS: This PR contains a breaking change, don't just backport directly