fix: Skip virtual doctypes in link field checks (backport #24759) #25332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit b6eef6e)
mergify
bot
requested review from
a team and
akhilnarang
and removed request for
a team
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
## [14.67.1](v14.67.0...v14.67.1) (2024-03-12) ### Bug Fixes * Add `is_virtual` in bootstrap schema ([cbc4640](cbc4640)) * **auto_email_report:** check if column (docfield) parent is a child table ([#25335](#25335)) ([#25341](#25341)) ([3f0c823](3f0c823)) * commit regardless of framework's transaction_writes count ([#25322](#25322)) ([#25327](#25327)) ([0ee8e30](0ee8e30)) * delete doctype cache before starting migration ([2c1e615](2c1e615)) * Delete EPS logs before deleting user (backport [#25248](#25248)) ([#25249](#25249)) ([0dee65c](0dee65c)) * do not mark custom field as translatable by default (backport [#25285](#25285)) ([#25329](#25329)) ([c46b7ff](c46b7ff)) * explicit optional ([71af71a](71af71a)) * ignore route history and access log from link check ([5344c8e](5344c8e)) * mac shortcuts ([ec9164f](ec9164f)) * missing timeline timestamp for comments ([294a0a3](294a0a3)), closes [/github.com//pull/24884/files#r1519195726](https://github.com//github.com/frappe/frappe/pull/24884/files/issues/r1519195726) * **ModuleDef:** Add list view filter options to app_name Select ([253e9a0](253e9a0)) * Private images in PDFs from background jobs ([#24980](#24980)) ([7d4eaa6](7d4eaa6)) * rollback invalid customize form changes (backport [#25198](#25198)) ([#25339](#25339)) ([e833e09](e833e09)) * show "Shift" symbol istead of text ([41759ff](41759ff)) * Skip virtual doctypes in link field checks ([#24759](#24759)) ([#25332](#25332)) ([3fe2372](3fe2372)) * **uninstall:** don't allow uninstalling an app if we have other apps dependent on it ([8d04076](8d04076))
|
🎉 This PR is included in version 14.67.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #24759 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com