Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow page length 2500 (backport #25062) #25484

Merged
merged 1 commit into from Mar 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 15, 2024

Multiple of our customers have recently expressed their struggle with loading many records: select page length 500, then klick load more, scroll down, load more, scroll down, ...

A long page length is useful for reports, when your filters result in a couple thousand records and you need to load and check (or print) all rows.

Why 2500? We always have 5x increments: 20, 100, 500, 2500

On my development site, the request take 115 ms for the server to process and about 4 seconds for the browser to render. This seems acceptable.


This is an automatic backport of pull request #25062 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner March 15, 2024 15:42
@mergify mergify bot requested review from ankush and removed request for a team March 15, 2024 15:42
@barredterra barredterra removed their assignment Mar 18, 2024
@ankush ankush merged commit 8a3ebc2 into version-15-hotfix Mar 19, 2024
16 of 20 checks passed
@ankush ankush deleted the mergify/bp/version-15-hotfix/pr-25062 branch March 19, 2024 17:26
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants