fix: redirect after login, todo filters #25521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks promising 🤔 |
|
Yeah. |
ankush
force-pushed
the
revert-25455-patch-5
branch
from
2da8a44
to
32183da
Compare
ankush
changed the title
ankush
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
* Revert "fix: default filter setup on todo list (#25455)" This reverts commit 396bc41. * Revert "Revert "fix: default filter setup on todo list (#25455)"" This reverts commit 5e6b699. * test: wait longer for filters to apply * fix: route redirects after login * test: use clear_filters * fix: don't set default filters on ToDo This messes with previous filters logic. (cherry picked from commit 571ca34) # Conflicts: # cypress/integration/awesome_bar.js # cypress/support/commands.js
ankush
added a commit
that referenced
this pull request
Mar 21, 2024
* fix: redirect after login, todo filters (#25521) * Revert "fix: default filter setup on todo list (#25455)" This reverts commit 396bc41. * Revert "Revert "fix: default filter setup on todo list (#25455)"" This reverts commit 5e6b699. * test: wait longer for filters to apply * fix: route redirects after login * test: use clear_filters * fix: don't set default filters on ToDo This messes with previous filters logic. (cherry picked from commit 571ca34) # Conflicts: # cypress/integration/awesome_bar.js # cypress/support/commands.js * chore: conflicts * chore: drop not-so-useful test --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
# [15.19.0](v15.18.2...v15.19.0) (2024-03-27) ### Bug Fixes * add missing arg while invoking _download_multi_pdf ([f82ed9f](f82ed9f)) * allow page length 2500 ([#25062](#25062)) ([75b1f6c](75b1f6c)) * **Contact form:** make email translatable ([800cfee](800cfee)) * **Contact form:** make title and options translatable ([b1dbd79](b1dbd79)) * **Contact form:** translate internal notification to system language ([f67e5f1](f67e5f1)) * DB Query distinct handling with full table name ([#25594](#25594)) ([4fe0498](4fe0498)) * diff after converting to html to text ([#25582](#25582)) ([#25584](#25584)) ([bd7372d](bd7372d)) * Mark totals row correctly for print ([#25629](#25629)) ([#25631](#25631)) ([725018f](725018f)) * only add title field in search if it exists ([#25634](#25634)) ([#25636](#25636)) ([b2260c1](b2260c1)) * redirect after login, todo filters (backport [#25521](#25521)) ([#25561](#25561)) ([d9f9aa4](d9f9aa4)), closes [#25455](#25455) [#25455](#25455) * respect `null` as number value ([#25639](#25639)) ([5b64ac9](5b64ac9)) * set list row height to 40px ([#25619](#25619)) ([#25625](#25625)) ([af406f9](af406f9)) * **test:** update RQ serialization test ([c764282](c764282)) * Translate form and workflow builder (backport [#25482](#25482)) ([#25547](#25547)) ([01f469f](01f469f)) * **webhook:** `r` is referenced here before its initialized ([a60bb4e](a60bb4e)), closes [#21064](#21064) * **workspace:** Don't allow Welcome as default workspace ([819a24c](819a24c)) ### Features * allow setting a custom rate limit for `login via email link` feature ([c7af627](c7af627)) * connect to redis sentinel for redis queue ([#25557](#25557)) ([82a33c3](82a33c3)) * drop sentry's RQ integration ([1eab176](1eab176)) * **workspace:** Allow user to choose a default workspace ([bfa1a83](bfa1a83)) ### Performance Improvements * Faster "show title in link field" on list view ([#25597](#25597)) ([#25622](#25622)) ([f62a30c](f62a30c)) * remove useless sorting on docstatus ([#25571](#25571)) ([#25591](#25591)) ([5e5853e](5e5853e)) ### Reverts * Revert "fix: escape text types before setting disp area (#25520) (#25523)" (#25603) ([bbf55df](bbf55df)), closes [#25520](#25520) [#25523](#25523) [#25603](#25603)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing if this is the cause behind recent breakage #25519 (comment)
Broken tests: https://cloud.cypress.io/projects/92odwv/runs/38126/test-results/f6f35d8a-a120-4c1f-9b9c-ec30387f2cc7?actions=%5B%5D&browsers=%5B%5D&groups=%5B%5D&isFlaky=%5B%5D&modificationDateRange=%7B%22startDate%22%3A%221970-01-01%22%2C%22endDate%22%3A%222038-01-19%22%7D&orderBy=EXECUTION_ORDER&oses=%5B%5D&specs=%5B%5D&statuses=%5B%7B%22value%22%3A%22FAILED%22%2C%22label%22%3A%22FAILED%22%7D%5D&testingTypesEnum=%5B%5D&utm_source=github