Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use base32 space for random names instead of base16 (backport #25497) #25546

Merged
merged 2 commits into from Apr 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 19, 2024

Better implementation of #25309

This has all the same benefits as before:

operation before after difference
read a single document w/ 1000 child table rows; MySQL pages read 885 8 100x reduction

With the added benefits:

  • names are sequential for at 32^4 /10 seconds (as opposed to completely random distribution)
  • Collision is far less likely now (base32 vs base16)

This is an automatic backport of pull request #25497 done by [Mergify](https://mergify.com).

(cherry picked from commit adf24b2)

# Conflicts:
#	frappe/model/naming.py
@mergify mergify bot requested a review from a team as a code owner March 19, 2024 17:46
@mergify mergify bot added the conflicts label Mar 19, 2024
@mergify mergify bot requested review from ankush and removed request for a team March 19, 2024 17:46
@mergify mergify bot assigned ankush Mar 19, 2024
Copy link
Contributor Author

mergify bot commented Mar 19, 2024

Cherry-pick of adf24b2 has failed:

On branch mergify/bp/version-15-hotfix/pr-25497
Your branch is up to date with 'origin/version-15-hotfix'.

You are currently cherry-picking commit adf24b24d4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frappe/tests/test_naming.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/model/naming.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ankush ankush closed this Mar 22, 2024
@mergify mergify bot deleted the mergify/bp/version-15-hotfix/pr-25497 branch March 22, 2024 12:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
@ankush ankush restored the mergify/bp/version-15-hotfix/pr-25497 branch April 25, 2024 11:58
@ankush ankush reopened this Apr 25, 2024
@ankush ankush enabled auto-merge (squash) April 25, 2024 12:00
@ankush ankush removed the conflicts label Apr 25, 2024
@ankush ankush merged commit 0723853 into version-15-hotfix Apr 25, 2024
17 checks passed
@ankush ankush deleted the mergify/bp/version-15-hotfix/pr-25497 branch April 25, 2024 12:18
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants