Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type error in workflow (backport #25847) #25848

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: type error in workflow (backport #25847) #25848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions frappe/public/js/frappe/model/workflow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,9 @@ frappe.workflow = {

var state =
doc[state_fieldname] || frappe.workflow.get_default_state(doctype, doc.docstatus);
if (!state) return false;

let allow_edit_roles = state
? frappe.workflow.get_document_state_roles(doctype, state)
: null;
let allow_edit_roles = frappe.workflow.get_document_state_roles(doctype, state);
let has_common_role = frappe.user_roles.some((role) =>
allow_edit_roles.includes(role)
);
Expand Down
Loading