feat: add option to set default email recipients (backport #25555) #25914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* feat: add option to set default email recipients
* fix: don't crash if no events
communication.js:206 Uncaught TypeError: Cannot read properties of undefined (reading 'events')
at frappe.views.CommunicationComposer.get_default_recipients (communication.js:206:16)
at frappe.views.CommunicationComposer.get_fields (communication.js:57:19)
at frappe.views.CommunicationComposer.make (communication.js:25:17)
at new frappe.views.CommunicationComposer (communication.js:16:8)
at Object.primary_action (communication__list_js:34:3)
at HTMLButtonElement.<anonymous> (list_view.js:1432:19)
at HTMLButtonElement.dispatch (jquery.js:5135:27)
at elemData.handle (jquery.js:4939:28)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
(cherry picked from commit 4c85626)
|
🎉 This PR is included in version 15.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when emailing a document, users have to manually select recipients, CC and BCC (recipients sometimes get filled from the document). However, in standard processes like Sales Order -> Delivery Note -> Sales Invoice, the email addresses are often pre-defined. This is done in advance by the account manager. It should not be the responsibility of the storekeeper or accountant to figure out the correct recipient and CC addresses.
This PR enables us to set default recipients via a Client Script. Every form can programmatically supply it's own default recipients.
CommunicationComposer(the email dialog) will check if there is a client script supplying default recipients. This will allow us to do things like:Docs: frappeframework.com/docs/user/en/api/form#form-events, frappeframework.com/docs/user/en/desk/scripting/client-script#3-6-set-default-email-recipients
This is an automatic backport of pull request #25555 done by [Mergify](https://mergify.com).