fix!: better "Export customizations" #25918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes things hard to read with code all over the place and tied to test name.
ankush
added
backport version-14-hotfix
If not sync_on_migrate right now this code isn't doing anything :hanky:
ankush
changed the title
This was referenced Apr 11, 2024
ankush
removed
backport version-14-hotfix
ankush
added a commit
that referenced
this pull request
Apr 12, 2024
* fix!: Sync property setter instead of overriding them (cherry picked from commit 526ff3b) * test: remove usage of _testMethodName Makes things hard to read with code all over the place and tied to test name. (cherry picked from commit 0fcd032) * test: prop setter syncing (cherry picked from commit 9245062) * fix(DX): Warn about custom docperm behaviour (cherry picked from commit 12a8e9e) * fix: Sync customization on first install if not sync_on_migrate If not sync_on_migrate right now this code isn't doing anything :hanky: (cherry picked from commit 51d41ea) --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush
added
backport version-14-hotfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use "Export customization" feature, the sync process will always override with customization stored in code. This is undesirable in most use cases.
Fixes:
sync_on_migrate=Falsenow at least syncs on install. If it was set to false the code wasn't doing anything 馃挬Closes #25458
This also isn't ideal. Deleted prop setters won't be "synced" every with this design... but that seems better than wiping out random unknown changes.