Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report_view): allow exporting all rows even if count is disabled (backport #26038) #26042

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 18, 2024

Before showing this checkbox, we were checking the total count.
However there's cases where customers have the length disabled, and they still want to export all rows.

Reference: support ticket 13593


This is an automatic backport of pull request #26038 done by [Mergify](https://mergify.com).

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
(cherry picked from commit 4549c69)
@mergify mergify bot requested a review from a team as a code owner April 18, 2024 10:51
@mergify mergify bot requested review from akhilnarang and removed request for a team April 18, 2024 10:51
@akhilnarang akhilnarang merged commit 7f11100 into version-14-hotfix Apr 18, 2024
9 of 11 checks passed
@akhilnarang akhilnarang deleted the mergify/bp/version-14-hotfix/pr-26038 branch April 18, 2024 11:46
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.73.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants