fix(grid_row): check child table dependent properties whenever a row is selected (backport #26054) #26067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…is selected Signed-off-by: Akhil Narang <me@akhilnarang.dev> (cherry picked from commit 3dc568e)
|
🎉 This PR is included in version 14.73.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, we have a single docfield for every row here. So the value
of fields like
read_onlyisn't true to the current row, but whateverwas last set. This breaks use cases where we have conditional read-only
or mandatory based on another value in the row - whatever was set last
ends up applying to every row (and basically since we skip the actual
evaluation if its already true - if any one row triggered read_only or
mandatory - all were forced into that)
Now everytime a row is selected, we set the dependent properties and for
that data so that it works as expected.
Resolves #25984, and support ticket 13288
This is an automatic backport of pull request #26054 done by [Mergify](https://mergify.com).