refactor: filters for export on prepared report #26106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if frappe.router.set_route is doing something wrong here and producing malformed urls. But the report view seems to work fine. |
ankush
added
backport version-14-hotfix
|
URL still seems broken? |
ankush
reviewed
Apr 23, 2024
|
This whole code is shit. The only reason why it's working is something else is buggy too
|
ankush
force-pushed
the
fix-prepared-report-export
branch
from
418afcd
to
3499e88
Compare
ankush
force-pushed
the
fix-prepared-report-export
branch
from
3499e88
to
b5b6a52
Compare
This was referenced Apr 23, 2024
ankush
added a commit
that referenced
this pull request
Apr 23, 2024
…-26106 refactor: filters for export on prepared report (backport #26106)
ankush
added a commit
that referenced
this pull request
Apr 24, 2024
…6116) * fix: filters on prepared report export (cherry picked from commit 71a9fa4) # Conflicts: # frappe/public/js/frappe/views/reports/query_report.js * refactor: Store prepared_report_name state on report obj (cherry picked from commit b5b6a52) # Conflicts: # frappe/core/doctype/prepared_report/prepared_report.js # frappe/public/js/frappe/views/reports/query_report.js --------- Co-authored-by: Rutwik Hiwalkar <rutwikhdev@gmail.com> Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the url generated by frappe.router.set_route on, prepared report > "Show Report"
frappe.urllib.get_dict("prepared_report_name") fails to parse this and prepared_report_name is left empty leaving the export data process in below state
ref: https://support.frappe.io/helpdesk/tickets/11816