Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "fix(grid_row): check child table dependent properties whenever a row is selected" #26110

Merged
merged 1 commit into from Apr 23, 2024
Merged

revert: "fix(grid_row): check child table dependent properties whenever a row is selected" #26110

merged 1 commit into from Apr 23, 2024

Conversation

akhilnarang
Copy link
Member

Reverts #26054

Causes some other breakage: #26107, better to figure out an alternate fix

@akhilnarang akhilnarang requested a review from a team as a code owner April 23, 2024 07:15
@akhilnarang akhilnarang requested review from ankush and removed request for a team April 23, 2024 07:15
@akhilnarang akhilnarang enabled auto-merge (squash) April 23, 2024 07:15
@akhilnarang akhilnarang added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels Apr 23, 2024
@akhilnarang akhilnarang linked an issue Apr 23, 2024 that may be closed by this pull request
Child Doctype check fieldtype is broken #26107
Closed
@akhilnarang akhilnarang merged commit 1620da5 into develop Apr 23, 2024
25 checks passed
@akhilnarang akhilnarang deleted the revert-26054-fix-child-table-row-dependent-properties branch April 23, 2024 07:29
mergify bot pushed a commit that referenced this pull request Apr 23, 2024
@akhilnarang @mergify
Revert "fix(grid_row): check child table dependent properties wheneve…
6be0435 
…r a row is selected" (#26110)

(cherry picked from commit 1620da5)
mergify bot pushed a commit that referenced this pull request Apr 23, 2024
@akhilnarang @mergify
Revert "fix(grid_row): check child table dependent properties wheneve…
b94f271 
…r a row is selected" (#26110)

(cherry picked from commit 1620da5)
This was referenced Apr 23, 2024
Merged
Merged
akhilnarang added a commit that referenced this pull request Apr 23, 2024
@mergify @akhilnarang
Revert "fix(grid_row): check child table dependent properties wheneve…
ff1036a 
…r a row is selected" (#26110) (#26112)

(cherry picked from commit 1620da5)

Co-authored-by: Akhil Narang <me@akhilnarang.dev>
akhilnarang added a commit that referenced this pull request Apr 23, 2024
@mergify @akhilnarang
Revert "fix(grid_row): check child table dependent properties wheneve…
57edd30 
…r a row is selected" (#26110) (#26113)

(cherry picked from commit 1620da5)

Co-authored-by: Akhil Narang <me@akhilnarang.dev>
@cogk
Copy link
Contributor

cogk commented Apr 23, 2024 •
edited

Also I just noticed that clicking the header row added the configure ( ⚙️ ) button multiple times 😄 + it broke stuff with Int/Float fields

@akhilnarang
Copy link
Member Author

Also I just noticed that clicking the header row added the configure ( ⚙️ ) button multiple times 😄 + it broke stuff with Int/Float fields

Ah rip, I just tested basic stuff with a table with 2 fields, there no difference. Basically need to figure out a way to do this without having to re-render.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush Awaiting requested review from ankush ankush was automatically assigned from frappe/frappe-review-team

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Child Doctype check fieldtype is broken
2 participants
@akhilnarang @cogk