Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc sys health report fixes (backport #26262) #26289

Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 2, 2024

  • fix: system health ergonomics
  • refactor: avoid deprecated method

This is an automatic backport of pull request #26262 done by [Mergify](https://mergify.com).

ankush added 2 commits May 2, 2024 07:21
- if redis is down it takes 10 second and doesn't indicate that
  correctly
- full traceback is shared in debug log, if some step fails

(cherry picked from commit b5bc8b3)
(cherry picked from commit 1a3c232)

# Conflicts:
#	frappe/core/doctype/comment/comment.py
@mergify mergify bot requested a review from a team May 2, 2024 07:21
@mergify mergify bot added the conflicts label May 2, 2024
@mergify mergify bot requested review from ankush and removed request for a team May 2, 2024 07:21
@mergify mergify bot assigned ankush May 2, 2024
Copy link
Contributor Author

mergify bot commented May 2, 2024

Cherry-pick of 1a3c232 has failed:

On branch mergify/bp/version-14-hotfix/pr-26262
Your branch is ahead of 'origin/version-14-hotfix' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 1a3c23290f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frappe/desk/doctype/tag/tag.py
	modified:   frappe/desk/doctype/todo/todo.py
	modified:   frappe/desk/like.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/core/doctype/comment/comment.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ankush ankush closed this May 2, 2024
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-26262 branch May 2, 2024 08:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant