perf: undebounce autocomplete #26491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barredterra autocomplete tests breaking 👀 Probably needs some delay (?) recording just shows everything going too fast and wrong. |
barredterra
force-pushed
the
undebounce-autocomplete
branch
2 times, most recently
from
5446b86
to
2febb65
Compare
barredterra
force-pushed
the
undebounce-autocomplete
branch
from
2febb65
to
cc4d369
Compare
|
@ankush I tried different combinations of typing + waiting, but can't seem to figure out what's cypress's problem. Currently it seems like it blurs/resets the input instead of selecting the option. Could you give it a try? |
|
@barredterra try very small debounce maybe 👀 100ms won't be noticeable to users. |
This comment was marked as outdated.
This comment was marked as outdated.
|
A smaller, 100 ms debounce also did not help, cypress still fails (see #26765). |
barredterra
added
backport version-14-hotfix
This was referenced Jun 20, 2024
|
@Mergifyio backport version-15-hotfix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most "Autocomplete" fields have their options set in advance, so debouncing on input is pointless here. For example, the Country field in Holiday List:
Before:
country-debounced.mov
After:
country-fast.mov
Even when calling an API, waiting for half a second significantly worsens the experience. For example, address autocompletion.
Before:
address-debounced.mov
After:
address-fast.mov
Removing this debounce results in a snappier UX and does not impose rate limiting, which is unnecessary in the first case and unwanted in the second.