Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: undebounce autocomplete (backport #26491) #26811

Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 20, 2024

Most "Autocomplete" fields have their options set in advance, so debouncing on input is pointless here. For example, the Country field in Holiday List:

Before:

country-debounced.mov

After:

country-fast.mov

Even when calling an API, waiting for half a second significantly worsens the experience. For example, address autocompletion.

Before:

address-debounced.mov

After:

address-fast.mov

Removing this debounce results in a snappier UX and does not impose rate limiting, which is unnecessary in the first case and unwanted in the second.


This is an automatic backport of pull request #26491 done by Mergify.

(cherry picked from commit 12d18fa)

# Conflicts:
#	frappe/public/js/frappe/form/controls/autocomplete.js
(cherry picked from commit c31cd09)
Copy link
Contributor Author

mergify bot commented Jun 20, 2024

Cherry-pick of 12d18fa has failed:

On branch mergify/bp/version-15-hotfix/pr-26491
Your branch is up to date with 'origin/version-15-hotfix'.

You are currently cherry-picking commit 12d18fa46c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/public/js/frappe/form/controls/autocomplete.js

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@barredterra
Copy link
Collaborator

Rebase after #26813 is merged

@barredterra barredterra marked this pull request as draft June 20, 2024 17:19
@barredterra
Copy link
Collaborator

@Mergifyio rebase

Copy link
Contributor Author

mergify bot commented Jun 20, 2024

rebase

☑️ Nothing to do

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position=-1 [📌 rebase requirement]
  • any of:
    • #commits-behind>0 [📌 rebase requirement]
    • #commits>1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@barredterra
Copy link
Collaborator

@Mergifyio dequeue

Copy link
Contributor Author

mergify bot commented Jun 20, 2024

dequeue

☑️ The pull request is not queued

@barredterra barredterra deleted the mergify/bp/version-15-hotfix/pr-26491 branch June 20, 2024 17:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant