-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kanban style #26538
feat: kanban style #26538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rutwikhdev I fixed the "add"-button background, but wouldn't want to make it more configurable. You can already configure the colors. The requirement of seeing a tiny colored dot instead of a noticeable background doesn't seem plausible to me. Either you want to visually distinguish columns or not. Btw, the failing UI test seems unrelated. |
* fix(Kanban): hide sidebar toggle * fix(Kanban): toggle full-width if more than five columns are visible * fix(Kanban): show correct cursor on column header * fix(Kanban): increase column height, add margin * fix(Kanban): increase card padding * feat(Kanban): set column background based on indicator * fix(Kanban): add-button background color * feat(Kanban): grow columns if there's leftover space * fix(Kanban): space between columns (cherry picked from commit 551a520)
For my board with 5 columns, this added unnecessary scroll when they could take up the whole screen fitting nicely. Although I cannot recommend another value as it might just be arbitrary, a lesser number works better for me. |
Reviving the style fixes from #17424
Changes
Before
After
Gray:
Colorful:
Kanban style