Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kanban style #26538

Merged
merged 9 commits into from
May 24, 2024
Merged

feat: kanban style #26538

merged 9 commits into from
May 24, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented May 22, 2024

Reviving the style fixes from #17424

Changes

  • Hide sidebar toggle
  • Toggle full-width if more than five columns are visible (not available)
  • Show correct cursor on column header
  • Increase column height, add margin
  • Increase card padding
  • Set column background based on indicator
    • I know, colors are controversial, but many people find them useful for visual separation of columns. If you don't like them, just don't set any indicator color.

Before

Bildschirmfoto 2024-05-22 um 16 10 59

After

Gray:

Bildschirmfoto 2024-05-22 um 17 32 10

Colorful:

Bildschirmfoto 2024-05-22 um 17 30 38
Kanban style

no-docs

@barredterra barredterra changed the title kanban style feat: kanban style May 22, 2024
@barredterra barredterra added the backport version-15-hotfix Backport the PR to v15 label May 22, 2024
@ankush ankush requested a review from rutwikhdev May 22, 2024 14:26
Copy link
Contributor

@rutwikhdev rutwikhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a check in Project/Kanban Settings? Since some people might prefer only indicators. Also the add button color looks hideous in some shades. It won't even show in gray bg. Try --bg-color instead.

image

@barredterra
Copy link
Collaborator Author

barredterra commented May 22, 2024

@rutwikhdev I fixed the "add"-button background, but wouldn't want to make it more configurable. You can already configure the colors. The requirement of seeing a tiny colored dot instead of a noticeable background doesn't seem plausible to me. Either you want to visually distinguish columns or not.

Btw, the failing UI test seems unrelated.

@rutwikhdev rutwikhdev merged commit 551a520 into develop May 24, 2024
44 of 45 checks passed
@rutwikhdev rutwikhdev deleted the kanban-style branch May 24, 2024 08:02
mergify bot pushed a commit that referenced this pull request May 24, 2024
* fix(Kanban): hide sidebar toggle

* fix(Kanban): toggle full-width if more than five columns are visible

* fix(Kanban): show correct cursor on column header

* fix(Kanban): increase column height, add margin

* fix(Kanban): increase card padding

* feat(Kanban): set column background based on indicator

* fix(Kanban): add-button background color

* feat(Kanban): grow columns if there's leftover space

* fix(Kanban): space between columns

(cherry picked from commit 551a520)
@gavindsouza
Copy link
Collaborator

Toggle full-width if more than five columns are visible (not available)

For my board with 5 columns, this added unnecessary scroll when they could take up the whole screen fitting nicely. Although I cannot recommend another value as it might just be arbitrary, a lesser number works better for me.

barredterra added a commit to barredterra/frappe that referenced this pull request May 29, 2024
ankush pushed a commit that referenced this pull request May 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants