Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(number_card): ensure value is returned (backport #26600) #26602

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 29, 2024

In the case of a number card based on a query report, an integer with
a very basic DF is passed, leading to the "formatted" value being just
the integer as a string, which becomes an empty string after $().text()

Reference: support ticket 15836


This is an automatic backport of pull request #26600 done by [Mergify](https://mergify.com).

In the case of a number card based on a query report, an integer with
a very basic DF is passed, leading to the "formatted" value being just
the integer as a string, which becomes an empty string after $().text()

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
(cherry picked from commit 7695a0d)
@mergify mergify bot requested a review from a team May 29, 2024 11:08
@mergify mergify bot requested review from ankush and removed request for a team May 29, 2024 11:08
@akhilnarang akhilnarang merged commit 1b62208 into version-15-hotfix May 29, 2024
19 checks passed
@akhilnarang akhilnarang deleted the mergify/bp/version-15-hotfix/pr-26600 branch May 29, 2024 11:56
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.29.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants