fix: bypass IP restriction for the methods required for our socketio backend (backport #26624) #26627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…backend Those requests are made from a separate backend, not by the user. Signed-off-by: Akhil Narang <me@akhilnarang.dev> (cherry picked from commit 68fd322)
mergify
bot
requested review from
a team and
ankush
and removed request for
a team
|
🎉 This PR is included in version 14.76.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: support ticket 15683
Socketio backend needs some information from the user, exposed via these endpoints:
For now this seems to be the best way, maybe in the future if we rewrite the socketio backend in python we can have this be a direct method call.
This is an automatic backport of pull request #26624 done by Mergify.