fix: don't excessively shorten_number #26760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce
Create two Number Cards, "With decimals" and "Without decimals", calling these two custom methods:
Before
The number with decimals is shortened to
"1 K"
, losing 23.457 % in precision. The number without decimals remains unchanged.Analysis
The call
shorten_number(1234.56789, "Germany", 5)
is expected to return a rough representation of the number (1234.56789
), using less than5
digits. This can already be achieved by rounding to the nearest integer.After
The number with decimals is rounded to the nearest integer, which is less than five digits, losing only 0.035 % in precision.