fix: don't excessively shorten_number (backport #26760)

[mergify]

Reproduce

Create two Number Cards, "With decimals" and "Without decimals", calling these two custom methods:

import frappe


@frappe.whitelist()
def with_decimals(filters=None):
	return {
		"value": 1234.56789,
		"fieldtype": "Float",
	}


@frappe.whitelist()
def without_decimals(filters=None):
	return {
		"value": 1234.0,
		"fieldtype": "Float",
	}

Before

The number with decimals is shortened to "1 K", losing 23.457 % in precision. The number without decimals remains unchanged.

Analysis

The call shorten_number(1234.56789, "Germany", 5) is expected to return a rough representation of the number (1234.56789), using less than 5 digits. This can already be achieved by rounding to the nearest integer.

After

The number with decimals is rounded to the nearest integer, which is less than five digits, losing only 0.035 % in precision.

---

This is an automatic backport of pull request #26760 done by Mergify.

[frappe-pr-bot]

🎉 This PR is included in version 15.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀