Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog_image to Blog Post #2886

Closed
wants to merge 0 commits into from
Closed

Add blog_image to Blog Post #2886

wants to merge 0 commits into from

Conversation

Alchez
Copy link
Contributor

@Alchez Alchez commented Mar 16, 2017

Functionality to add images to blog posts and have them appear in the blog page and blog list.

screenshot from 2017-03-18 00-24-01
screenshot from 2017-03-18 00-24-44
screenshot from 2017-03-18 00-25-39

@netchampfaris
Copy link
Contributor

netchampfaris commented Mar 17, 2017

@Alchez Screenshots?

@Alchez
Copy link
Contributor Author

Alchez commented Mar 17, 2017

@netchampfaris Hey Faris, I've attached some sample images. Thanks!

Copy link
Contributor

@netchampfaris netchampfaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need a separate image field. We can just pull the first image from the content html, and show it as banner. Medium does the same.

@@ -1,7 +1,10 @@
{%- set post = doc -%}
<div class="web-list-item blog-list-item">
<div class="row">
<div class="col-xs-12">
<div class="col-xs-6">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be if here, if there is no image, existing layouts should work as it is
{% if blog_image %}

@neilLasrado
Copy link
Contributor

@Alchez Please make the necessary changes.

@Alchez Alchez closed this Mar 29, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants