Hotfix to allow for modal to be scrolled

[spa49]

modal´s scrollbar was hidden by modal-backdrop hence could not be scrolled

according to this

[rmehta]

@spa49 can you please add an animated GIF for before and after, so we understand the impact of your fix?

https://github.com/frappe/erpnext/wiki/Contribution-Guidelines

[netchampfaris]

Please edit the desk.less file

[spa49]

Hi @netchampfaris
I also changed the .less file since only changing less file and not .css file dint do anything
Is this right?
I´m not familiar with .less but if it is for dynamic styling why didnt it do anything after bench build and clear website cache?
I thought less is either to build a .css or to be used standalone... however according to chrome console the desk.css is the one controling the item modal-backdrop.
please clarify

[spa49]

@rmehta
Sorry, actually didnt read the CGL to be honnest - now I did.

My personal protocoll is documentation with .gif etc only from 10+ lines changed or in general for severe programatic changes ... everything alse I just visualize Q n D plus Im so bold not to take style sheets serious enough - @netchampfaris has proven me wrong there as well ;-)
However my appologies.

so again....
If you want to send an email from document view you go via "Menu" - "Email" into the Modal.
If said Modal´s content exceeds the hight of the screen one would wish to scroll - however scrolling is prevented as scroll bar can not be selected via mouse/cursor. this is caused by the modal-backdrop item having a fixed position ( firefox clearly shows that the scroll bar is hidden behind the modal-backdrop, also not selectable , chrome however displays scroll bar in front of modal-backdrop but does not allow to be scrolled. If scoll bar is clicked/selected the modal closes
please see before.gif in chrome

with the in PR proposed changes the scroll bar is usable
please see after.gif in chrome

hope that clears it up... will remember in the future:-)