Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix to allow for modal to be scrolled #5486

Merged
merged 3 commits into from
May 2, 2018
Merged

Hotfix to allow for modal to be scrolled #5486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
890883e
Merge pull request #6 from frappe/hotfix
spa49 Apr 24, 2018
1234ba1
Update desk.css
spa49 Apr 24, 2018
204eb5a
Update desk.less
spa49 Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion frappe/public/css/desk.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ fieldset[disabled] .form-control {
}
.modal-backdrop {
opacity: 0.5;
position: fixed;
position: absolute;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the desk.less file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @netchampfaris
I also changed the .less file since only changing less file and not .css file dint do anything
Is this right?
I´m not familiar with .less but if it is for dynamic styling why didnt it do anything after bench build and clear website cache?
I thought less is either to build a .css or to be used standalone... however according to chrome console the desk.css is the one controling the item modal-backdrop.
please clarify

}
.modal-header {
padding: 10px 15px;
Expand Down
2 changes: 1 addition & 1 deletion frappe/public/less/desk.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ textarea.form-control {

.modal-backdrop {
opacity: 0.5;
position: fixed;
position: absolute;
}

.modal-header {
Expand Down