fix(login): redirect user from login page if already logged in #6689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the user should not be able to access the login page if a user session already exists. closes frappe#6500. Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
what is the point in writing tests if they don't really work/function as intended? Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
that defeats the entire purpose of creating rules, wtf? Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
Thunderbottom
force-pushed
the
login-redirect-fix
branch
from
c802c68
to
adad284
Compare
Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
…into login-redirect-fix
netchampfaris
approved these changes
Dec 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user should not be able to access the login page if a user session already exists.
closes #6500.