feat: Allow more field types in group by fields #9767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instanceof fails to check for string, instead classifying the
$target.data('value') as instanceof Object; which causes the ternary
check to fail and pass filter without decodeURIComponent(), causing
filter to be applied like: email%40example.com instead of
email@example.com
we can instead just use typeof to check whether the passed value is a
string
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
surajshetty3416
changed the title
surajshetty3416
approved these changes
Mar 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port-of: #9761