fix: consider payment days = total working days in the last salary slip while calculating Gratuity #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ip while calculating Gratuity
ruchamahabal
force-pushed
the
fix-gratuity
branch
from
20bfd5d
to
52835d2
Compare
ruchamahabal
changed the title
- to avoid passing around args repetitively
ruchamahabal
force-pushed
the
fix-gratuity
branch
2 times, most recently
from
20dc9ab
to
2f4c971
Compare
- make gratuity settings a class property to avoid refetching - get rid of unnecessary variables - extract complex conditions into bool functions
ruchamahabal
force-pushed
the
fix-gratuity
branch
from
2f4c971
to
4b1437b
Compare
ruchamahabal
force-pushed
the
fix-gratuity
branch
from
7f8f919
to
e474d86
Compare
ruchamahabal
added a commit
that referenced
this pull request
May 24, 2024
…1806 fix: consider payment days = total working days in the last salary slip while calculating Gratuity (backport #1806)
ruchamahabal
added a commit
that referenced
this pull request
May 24, 2024
…1806 fix: consider payment days = total working days in the last salary slip while calculating Gratuity (backport #1806)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gratuity is calculated based on last drawn salary but if the employee worked for less number of days in the last payroll cycle, gratuity amount gets affected.
Always keep payment days = total working days irrespective of attendance making it non-deterministic