fix: consider payment days = total working days in the last salary slip while calculating Gratuity (backport #1806) #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…ip while calculating Gratuity (cherry picked from commit 52835d2)
- to avoid passing around args repetitively (cherry picked from commit c07543e)
- make gratuity settings a class property to avoid refetching - get rid of unnecessary variables - extract complex conditions into bool functions (cherry picked from commit 4b1437b)
(cherry picked from commit 6ac2da5)
- remove unnecessary test (cherry picked from commit e474d86)
|
🎉 This PR is included in version 14.28.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gratuity is calculated based on last drawn salary but if the employee worked for less number of days in the last payroll cycle, gratuity amount gets affected.
Always keep payment days = total working days irrespective of attendance making it non-deterministic
This is an automatic backport of pull request #1806 done by Mergify.