Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't overwrite leave approver while rendering leave summary dashboard (backport #1858) #1860

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix: don't overwrite leave approver while rendering leave summary dashboard (backport #1858) #1860

merged 2 commits into from
Jun 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 7, 2024

  • If there are multiple leave approvers set at the department level and you select the second one for the employee, it gets reset to the first set approver in the table since the make_dashboard function overwrites it on refresh. Regression from feat(minor): Show leave allocation table in Leave Application on refresh hook #1375
  • Fix: decouple dashboard creation from leave approver setting since approver is already set on employee change trigger
  • UX fix: link employee & department doc in the error message for missing leave approver
image

Closes: #1764

This is an automatic backport of pull request #1858 done by [Mergify](https://mergify.com).

@ruchamahabal @mergify
fix: don't overwrite leave approver while renderingleave summary dash…
841a1dc 
…board

- leave approver is already set on employee selection after rendering dashboard, decouple both actions

(cherry picked from commit 2eb1461)
@ruchamahabal @mergify
fix(UX): link employee & department doc in the error message for miss…
2ba079b 
…ing leave approver

(cherry picked from commit e40ba0b)
@mergify mergify bot requested a review from ruchamahabal as a code owner June 7, 2024 06:03
@ruchamahabal ruchamahabal merged commit c575c32 into version-15-hotfix Jun 7, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/version-15-hotfix/pr-1858 branch June 7, 2024 06:23
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.22.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal Awaiting requested review from ruchamahabal ruchamahabal is a code owner

Assignees

@ruchamahabal ruchamahabal

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frappe-pr-bot @ruchamahabal