-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remote builder #1631
refactor: remote builder #1631
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
+ Coverage 38.66% 38.69% +0.03%
==========================================
Files 316 317 +1
Lines 25172 25357 +185
==========================================
+ Hits 9733 9813 +80
- Misses 15439 15544 +105 ☔ View full report in Codecov by Sentry. |
pass dc_name when uploading
- fix minor parsing bugs
thanks for this ❤️ - been so annoyed by having to constantly keep an eye on error log. |
I am 75% sure the failing tests are unrelated to my PR (they're failing elsewhere too). And so I'm merging it, this really shouldn't be FC workflow, but it is. Will address it soon. |
refactor: remote builder (continuation #1631)
This PR is to be a refactor of #1475.
While the previous implementation works, it has a few issues that make it unsuitable for production and long term:
docker build
fails, press mostly just receives aCalledProcessError
with irrelevant traceback. One needs to dive into agent logs to figure out what went wrong.deploy_candidate.py
this is not a feasible approach, the code between the two has already diverged.Agent side: frappe/agent#94
Note: this PR is incomplete, remote builder still isn't entirely ready, but since this PR has grown to above 1.2k line changes, I'm merging it as checkpoint.
TODO (will be addressed in a future PR):
Things completed: