Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flush output even on fail #1665

Merged
merged 3 commits into from
Apr 4, 2024
Merged

fix: flush output even on fail #1665

merged 3 commits into from
Apr 4, 2024

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Apr 4, 2024

Fixes a few issues in: #1631

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 69.44444% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 39.20%. Comparing base (2624123) to head (1539785).
Report is 11 commits behind head on master.

❗ Current head 1539785 differs from pull request most recent head 73c1e02. Consider uploading reports for the commit 73c1e02 to get more accurate results

Files Patch % Lines
...press/doctype/deploy_candidate/deploy_candidate.py 62.06% 11 Missing ⚠️
.../doctype/deploy_candidate/docker_output_parsers.py 68.57% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
+ Coverage   38.72%   39.20%   +0.48%     
==========================================
  Files         317      317              
  Lines       25371    25407      +36     
==========================================
+ Hits         9824     9960     +136     
+ Misses      15547    15447     -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- fix step key, fetching and updating
- fix do not send mail if admin
@18alantom 18alantom merged commit dd45c7f into master Apr 4, 2024
2 of 4 checks passed
@18alantom 18alantom deleted the flush-output branch April 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant