Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix/Riot : Emoji code and Markdown formatting are not interpreted ? #63

Open
Auroch opened this issue Aug 19, 2019 · 2 comments · May be fixed by #107
Open

Matrix/Riot : Emoji code and Markdown formatting are not interpreted ? #63

Auroch opened this issue Aug 19, 2019 · 2 comments · May be fixed by #107

Comments

@Auroch
Copy link

Auroch commented Aug 19, 2019

Hello, I have just configured the plugin and I notice that the emoji codes already proposed in the messages (or others) are not interpreted in the chat rooms.

I have already noticed that in the Riot client, you have to choose the emoji from a list while typing your text, if you leave the code :dog:, it is not interpreted as 🐶, so it may be a problem of the same order, or even a design difficulty in Matrix. But since there may be something to do on the plugin side, I prefer to report it.

On the other side, the MarkDown code is correctly interpreted in the Riot client, once the message is sent, bold, italics, etc. , it 'll appear correctly. But not if we use them in Octoslack... an idea of what could cause this?

Here, no rush, just the desire to bring up a detail to make this fantastic plugin even more attractive: -)

@nordurljosahvida
Copy link

@Auroch OT: how did you specify matrix room? !id:domain or #id:domain? thanks

@dwmunster
Copy link

dwmunster commented Nov 21, 2020

I am also experiencing this issue and available to test.

The issue is that messages are sent as rendered HTML (https://github.com/fraschetti/Octoslack/blob/master/octoprint_Octoslack/__init__.py#L4349). Thus, any markdown/emoji must be processed on the Octoslack side if you want them to display properly. Sending the html symbol (e.g. ➖) works just fine.

Edit: Using the emoji directly in the message also works. (i.e. 😕)

RealDekkia added a commit to RealDekkia/Octoslack that referenced this issue Dec 8, 2020
This fixes fraschetti#63 
It also makes the config more readable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants