Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include date of when longest tourism streak ended #292

Closed
lauracowen opened this issue Aug 14, 2021 · 3 comments
Closed

Include date of when longest tourism streak ended #292

lauracowen opened this issue Aug 14, 2021 · 3 comments

Comments

@lauracowen
Copy link
Collaborator

Would be great to have the longest tourism streak to include the date of when the streak ended?

Longest tourism streak 6 parkruns (ended 14 August 2020 at Alice Holt)

(Paul Blacknell)

@JazzyJ87
Copy link
Contributor

I suggest that when a new streak equals that of the previous streak, it supersedes it; as it would be more useful to know if your latest streak is the longest. Also, if your current streak is the longest then it hasn't technically ended. Perhaps 'to' should replace 'ended'?

image

@blacknell
Copy link

blacknell commented Aug 17, 2021

I'd agree other than the last point. It's a streak nonetheless. If I'd just bettered my previous one, it'd count in my book.

Rather than 'ended' perhaps 'achieved' which would work in both scenarios and keep logic simple.

JazzyJ87 added a commit to JazzyJ87/running-challenges that referenced this issue Aug 17, 2021
Include date & event where longest tourism streak ended fraz3alpha#292
fraz3alpha pushed a commit that referenced this issue May 21, 2022
* Update challenges.js

Include date & event where longest tourism streak ended #292
@blacknell
Copy link

Closes #294 - can someone close this issue as it's done! thanks by the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants