-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Component preview layout only renders if not in the compound component folder #3
Comments
This is actually expected behaviour - a component folder (one in which the name of the folder matches the name of the component view template) can't contain other components, which the preview layout is. regular folders (collections) can contain multiple components however. Should add something to the docs about this though maybe. Does that make sense? Is the difference between a 'collection' and a component in a directory clear? |
Ah right, it does makes sense. I may be trying to be too precise, but if I wanted to have a specific preview for each (or many) components, I would end up with a lot of preview layouts (somewhere). Not a big issue, but worth pointing out. |
Yeah I can see that. I guess I just didn't think of preview layouts as much more than just adding stylesheet and JS links so didn't imagine needing more than a couple. I could maybe make it so that if you have a I'll have a think if that has any other implications... |
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.13) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.13) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.13) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.13) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Given a component (
hr.hbs
):with the following config (
hr.config.yml
):and the following preview layout (
_preview.hbs
):A component is only rendered if the preview layout is in a folder above the compound folder. So this:
doesn’t work, but this:
does. Is this the expected behaviour?
The text was updated successfully, but these errors were encountered: