Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict with pytest-json #9

Closed
jacebrowning opened this issue Jul 27, 2018 · 4 comments
Closed

Conflict with pytest-json #9

jacebrowning opened this issue Jul 27, 2018 · 4 comments

Comments

@jacebrowning
Copy link
Contributor

I'm not sure if this is a bug in pytest-json or pytest-tldr:

Traceback (most recent call last):
  File ".../bin/pytest", line 11, in <module>
    sys.exit(main())
  File ".../lib/python3.7/site-packages/_pytest/config/__init__.py", line 64, in main
    return config.hook.pytest_cmdline_main(config=config)
  File ".../lib/python3.7/site-packages/pluggy/__init__.py", line 617, in __call__
    return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
  File ".../lib/python3.7/site-packages/pluggy/__init__.py", line 222, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File ".../lib/python3.7/site-packages/pluggy/__init__.py", line 216, in <lambda>
    firstresult=hook.spec_opts.get('firstresult'),
  File ".../lib/python3.7/site-packages/pluggy/callers.py", line 180, in _multicall
    res = hook_impl.function(*args)
  File ".../lib/python3.7/site-packages/pluggy/callers.py", line 76, in get_result
    raise ex[1].with_traceback(ex[2])
  File ".../lib/python3.7/site-packages/pluggy/callers.py", line 180, in _multicall
    res = hook_impl.function(*args)
  File ".../lib/python3.7/site-packages/_pytest/main.py", line 208, in pytest_cmdline_main
    return wrap_session(config, _main)
  File ".../lib/python3.7/site-packages/_pytest/main.py", line 178, in wrap_session
    session.exitstatus = doit(config, session) or 0
  File ".../lib/python3.7/site-packages/pluggy/__init__.py", line 617, in __call__
    return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
  File ".../lib/python3.7/site-packages/pluggy/__init__.py", line 222, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File ".../lib/python3.7/site-packages/pluggy/__init__.py", line 216, in <lambda>
    firstresult=hook.spec_opts.get('firstresult'),
  File ".../lib/python3.7/site-packages/pluggy/callers.py", line 201, in _multicall
    return outcome.get_result()
  File ".../lib/python3.7/site-packages/pluggy/callers.py", line 76, in get_result
    raise ex[1].with_traceback(ex[2])
  File ".../lib/python3.7/site-packages/pluggy/callers.py", line 180, in _multicall
    res = hook_impl.function(*args)
  File ".../lib/python3.7/site-packages/pytest_tldr.py", line 282, in pytest_sessionfinish
    terminalreporter=self, exitstatus=exitstatus
  File ".../lib/python3.7/site-packages/pluggy/__init__.py", line 617, in __call__
    return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
  File ".../lib/python3.7/site-packages/pluggy/__init__.py", line 222, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File ".../lib/python3.7/site-packages/pluggy/__init__.py", line 216, in <lambda>
    firstresult=hook.spec_opts.get('firstresult'),
  File ".../lib/python3.7/site-packages/pluggy/callers.py", line 201, in _multicall
    return outcome.get_result()
  File ".../lib/python3.7/site-packages/pluggy/callers.py", line 76, in get_result
    raise ex[1].with_traceback(ex[2])
  File ".../lib/python3.7/site-packages/pluggy/callers.py", line 180, in _multicall
    res = hook_impl.function(*args)
  File ".../lib/python3.7/site-packages/pytest_jsonreport/plugin.py", line 136, in pytest_terminal_summary
    terminalreporter.write_sep('-', 'JSON report')
AttributeError: 'TLDRReporter' object has no attribute 'write_sep'
@freakboy3742
Copy link
Owner

Looks like that might be tldr's problem - it's missing the write_sep method. Should be easy enough to add - thanks for the report!

freakboy3742 added a commit that referenced this issue Jul 28, 2018
@freakboy3742
Merge pull request #10 from freakboy3742/json-compat
cd3e55a 
Fixes #9 -- Restore output methods on TerminalReporter replacement.
@freakboy3742
Copy link
Owner

I've just released 0.1.5 that includes this fix.

@pseudotensor
Copy link

I have 0.1.5 and I still get this:

Traceback (most recent call last):
  File "/home/jon/.pyenv/versions/3.6.4/bin/pytest", line 11, in <module>
    sys.exit(main())
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/_pytest/config.py", line 61, in main
    return config.hook.pytest_cmdline_main(config=config)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/__init__.py", line 617, in __call__
    return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/__init__.py", line 222, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/__init__.py", line 216, in <lambda>
    firstresult=hook.spec_opts.get('firstresult'),
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/callers.py", line 201, in _multicall
    return outcome.get_result()
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/callers.py", line 76, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/callers.py", line 180, in _multicall
    res = hook_impl.function(*args)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/_pytest/main.py", line 138, in pytest_cmdline_main
    return wrap_session(config, _main)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/_pytest/main.py", line 132, in wrap_session
    exitstatus=session.exitstatus)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/__init__.py", line 617, in __call__
    return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/__init__.py", line 222, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/__init__.py", line 216, in <lambda>
    firstresult=hook.spec_opts.get('firstresult'),
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/callers.py", line 201, in _multicall
    return outcome.get_result()
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/callers.py", line 76, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/callers.py", line 180, in _multicall
    res = hook_impl.function(*args)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pytest_tldr.py", line 282, in pytest_sessionfinish
    terminalreporter=self, exitstatus=exitstatus
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/__init__.py", line 617, in __call__
    return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/__init__.py", line 222, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/__init__.py", line 216, in <lambda>
    firstresult=hook.spec_opts.get('firstresult'),
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/callers.py", line 201, in _multicall
    return outcome.get_result()
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/callers.py", line 76, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/pluggy/callers.py", line 180, in _multicall
    res = hook_impl.function(*args)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/_pytest/runner.py", line 41, in pytest_terminal_summary
    tr.write_sep("=", "slowest %s test durations" % durations)
AttributeError: 'TLDRReporter' object has no attribute 'write_sep'

@freakboy3742
Copy link
Owner

@pseudotensor Are you sure you've got 0.1.5? Can you provide a pip freeze listing?

Also - what other pytest plugins do you have installed? What's your minimum case for reproducing this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@freakboy3742 @jacebrowning @pseudotensor