Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

Commit

Permalink
Remove some completed todos [ci skip]
Browse files Browse the repository at this point in the history
  • Loading branch information
freaktechnik committed Sep 10, 2017
1 parent 615d702 commit 67a2315
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 15 deletions.
1 change: 0 additions & 1 deletion src/background/channel/live-state.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* @author Martin Giger
* @license MPL-2.0
* @module channel/live-state
* @todo Replace alternate properties with a serialized channel (to avoid require loops)
*/
import { omit } from "lodash";
import prefs from "../../preferences";
Expand Down
3 changes: 0 additions & 3 deletions src/background/channel/read-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
* @license MPL-2.0
* @module channel/list
* @requires module:channel/core
* @todo should fire close when the db is closed by event.
* @todo move out of background
* @todo Unify Errors that other lists might re-use.
*/
import ReadChannelList from '../../read-channel-list';
import { Channel, User } from "./core";
Expand Down
3 changes: 0 additions & 3 deletions src/background/error-state.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
* @author Martin Giger
* @license MPL-2.0
* @module error-state
* @todo Show warnings in options page and potentially the manager.
* @todo detach List instead of checking for error states to exist in it.
*/

import EventTarget from 'event-target-shim';
Expand Down Expand Up @@ -158,7 +156,6 @@ export default class ErrorState extends EventTarget {
text: ""
});
ErrorState.replacePanel(ErrorState.oldPopupURL);
//TODO icon & title back to normal
}
// Don't care about any other state downgrade, since unrecoverable errors
// shouldn't be recovered at runtime.
Expand Down
1 change: 0 additions & 1 deletion src/background/list.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
* @module list
* @requires module:channel/utils
* @requires module:list/firefox
* @todo need to know badge stuff when constructed, not when popup opened (i.e rewrite that now with the list having its own db connection to load).
*/
// setup event handling
import { emit } from "../utils";
Expand Down
4 changes: 0 additions & 4 deletions src/list/components/channels.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ Redirecting.propTypes = {
onRedirectorClick: PropTypes.func.isRequired
};

//TODO size of avatar changes when compact
const InnerChannel = (props) => {
let extras,
redirecting,
Expand Down Expand Up @@ -166,7 +165,6 @@ class Channel extends NavigateableItem {
className += ' nonlive';
}
this.props.children.push(<InnerChannel image={ this.props.image } uname={ this.props.uname } title={ this.props.title } extras={ this.props.extras } liveState={ this.props.liveState } redirectors={ this.props.redirectors } imageSize={ this.props.imageSize } onRedirectorClick={ this.props.onRedirectorClick } key="inner"/>);
//TODO can I use onCopy to trigger the copy action?
const element = super.render();
return React.cloneElement(element, {
title: this.props.uname,
Expand Down Expand Up @@ -227,7 +225,6 @@ const channelsShape = PropTypes.arrayOf(PropTypes.shape({
url: PropTypes.string,
})),
ChannelList = (props) => {
//TODO switch channels with arrow keys
const channels = props.channels.map((ch) => {
const onClick = ch.external ? (e) => {
e.preventDefault();
Expand Down Expand Up @@ -444,7 +441,6 @@ const getVisibleChannels = (state) => {
};

const mapStateToProps = (state) => {
//TODO explore panel
return {
channels: getVisibleChannels(state),
extras: state.settings.extras,
Expand Down
1 change: 0 additions & 1 deletion src/list/components/tabstrip.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ class TabStrip extends NavigateableList {
}

render() {
//TODO switch tabs with arrow keys
this.props.children = [
(<Tab title="panel_tab_live" onClick={ () => this.props.onTabSelect(0) } active={ this.props.active === 0 } key="0"/>)
];
Expand Down
1 change: 0 additions & 1 deletion src/list/reducers.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ const THEMES = [
}
},
channels = (state = [], event) => {
//TODO somehow channels are duplicating
switch(event.type) {
case "addChannels":
return state.concat(event.payload);
Expand Down
1 change: 0 additions & 1 deletion src/options/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
}
}
function printPref(pref){
//TODO print description if availble
let input = "";
if(pref.type == "radio") {
let options = "";
Expand Down

0 comments on commit 67a2315

Please sign in to comment.