This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
adjust buildscript to work inside wsl #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopefully this doesn't break macos compatibility also addedd IDE config and submodule to gitignore
|
Thanks for making it compatible with WSL 🙌🏻 I was planning to install docker on a Windows machine to see if the build script was working there, so i really appreciate this contribution. Confirmed that the script is working on MacOS with these changes, added the |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First and foremost: thanks for this idea / repo, was exactly what I was trying to "find out on my own" after getting my ender 3 back up and running to streamline firmware building.
Hopefully my changes don't break MacOS compatibility.
My WSL (Ubuntu 18.04) shell defaults to dash (/bin/sh is a symlink to /bin/dash) and not bash so the buildscript didn't work. Also my IDE complained about a couple of code-style issues but hopefully nothing major that breaks on MacOS, maybe you can double-check if it still works.
Also added IDE config and submodule to gitignore so they don't clutter up the commits / accidentally get commited
Oh and last but not least: It's Hacktober, mind marking my PR as "hacktoberfest-accepted" or adding the topic "hacktoberfest" to your project? maybe more contributors will follow :)