Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Auth0 oauth2 plugin #162

Merged
merged 9 commits into from
Aug 18, 2022
Merged

Adds Auth0 oauth2 plugin #162

merged 9 commits into from
Aug 18, 2022

Conversation

hw202207
Copy link
Contributor

  • Auth0 works per tenant base hence doesn't have a good idea to add to the example.

pbrisbin
pbrisbin reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but can you say more about why you can't add it to the examples? How do you know it's working?

src/Yesod/Auth/OAuth2/Auth0.hs Outdated Show resolved Hide resolved
src/Yesod/Auth/OAuth2/Auth0.hs Outdated Show resolved Hide resolved
@hw202207 hw202207 requested a review from pbrisbin August 17, 2022 22:27
@pbrisbin pbrisbin enabled auto-merge (rebase) August 18, 2022 12:48
pbrisbin
pbrisbin approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pbrisbin pbrisbin merged commit e7fa28c into freckle:main Aug 18, 2022
@pbrisbin
Copy link
Member

Released in v0.7.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrisbin pbrisbin pbrisbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hw202207 @pbrisbin @restyled-commits