Disable special case IJulia integration for now #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredo-dedup Did you have a chance to look at this? I am trying to finish the prep for my juliacon talk and it would be great to know whether I will have a tagged version of VegaLite with this PR merged available or not next week. Thanks! |
|
V0.0.4 has been tagged. Thanks for your help !
Le 15 juin 2017 6:31 AM, "David Anthoff" <notifications@github.com> a
écrit :
@fredo-dedup <https://github.com/fredo-dedup> Did you have a chance to look
at this? I am trying to finish the prep for my juliacon talk and it would
be great to know whether I will have a tagged version of VegaLite with this
PR merged available or not next week. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACt1gtTCQAyieb0OtX272Tv_AAvaFFKOks5sELOvgaJpZM4N3t4h>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't get the IJulia integration working without this. With this patch, IJulia just falls back to the new
showmethod that sends a PNG file over to IJulia, i.e. things work.It would of course be nicer to use the vega-lite embedding stuff, but something is broken with that.
Maybe we can merge this for now, until you or I or someone else gets the embedding stuff up and running again? I.e. just have this one here for a tagged version for juliacon, and then try to fix it.