Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude packages #142

Merged
merged 15 commits into from
Mar 16, 2023
Merged

Exclude packages #142

merged 15 commits into from
Mar 16, 2023

Conversation

fredrikaverpil
Copy link
Owner

@fredrikaverpil fredrikaverpil commented Mar 14, 2023

Why is the change needed?

What was done in this PR?

  • Added the --exclude-deps argument.
  • Refactorings.

Are there any concerns, side-effects, additional notes?

  • I've been mixing terminologies... the README.md mentions dependencies and packages interchangeably. Should probably settle on one of them and keep things consistent. This also applies to the source code. Doesn't need to part of this PR although it could affect the argument name;
    • --exclude-packages
    • --exclude-dependencies
    • --exclude-deps

Checklist, when applicable

@fredrikaverpil fredrikaverpil self-assigned this Mar 14, 2023
@fredrikaverpil fredrikaverpil marked this pull request as draft March 14, 2023 14:53
@fredrikaverpil fredrikaverpil mentioned this pull request Mar 14, 2023
4 tasks
@fredrikaverpil
Copy link
Owner Author

fredrikaverpil commented Mar 15, 2023

I'm considering renaming everything in the source code from package and dependency into dep. This also means keeping --deps-file and here introducing --excluded-deps. The README will be updated to only mention "dependencies" and not "packages". I'll sleep on this now.

@fredrikaverpil fredrikaverpil marked this pull request as ready for review March 16, 2023 19:46
@fredrikaverpil fredrikaverpil merged commit 58f484f into main Mar 16, 2023
@fredrikaverpil fredrikaverpil deleted the exclude-packages branch March 16, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An --ignores argument?
1 participant