Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up test suite #143

Closed
2 of 4 tasks
fredrikaverpil opened this issue Mar 14, 2023 · 3 comments
Closed
2 of 4 tasks

Speed up test suite #143

fredrikaverpil opened this issue Mar 14, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request Stale

Comments

@fredrikaverpil
Copy link
Owner

fredrikaverpil commented Mar 14, 2023

What feature request would you like to suggest?

Instead of actually calling pip or poetry, I'd like to get rid of these slow tests and instead mock and use fast unit testing. Some refactoring is being made in #142 which will make it easier to mock the dependency file reader. Pytest fixtures should be made for adding dependencies, excluding dependencies, returning a deps/venv/distlib/canonicalization resolve etc.

  • Add enough fixtures and tests around defining packages/venv etc so that the slow integration tests can be replaced with faster and equally reliable tests.
  • Would also be nice to add a coverage report, so to easily spot uncovered logic.
  • Would like to remove poetry as a required dependency for running the test suite.
  • Use built in caching from actions/setup-python:
- uses: actions/setup-python@v4
  with:
    cache: 'pip'
    cache-dependency-path: 'pyproject.toml'

Will the feature request break backwards compatibility?

No.

@fredrikaverpil fredrikaverpil added the enhancement New feature or request label Mar 14, 2023
@fredrikaverpil fredrikaverpil self-assigned this Mar 14, 2023
@github-actions
Copy link

This issue has been open for 7 days with no activity. Remove the stale label or add a comment or it will be closed in 3 days.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This issue has been open for 7 days with no activity. Remove the stale label or add a comment or it will be closed in 3 days.

@github-actions github-actions bot added the Stale label Apr 7, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

1 participant