Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test mode where clap-host ignores cookies #25

Closed
wants to merge 1 commit into from

Conversation

baconpaul
Copy link
Contributor

Add a test mode wher clap-host sets all param cookies to nullptr.

Add a test mode wher clap-host sets all param cookies to
nullptr.
@abique
Copy link
Contributor

abique commented Sep 27, 2022

The getenv() approach isn't right, it'd be an hidden feature, best would be a toggle in the menu maybe?

@baconpaul
Copy link
Contributor Author

Ok well I don’t know how to do thst!

can we collaborate here and you make a menu item which toggles thst state global? These are all the correct intercept points

@baconpaul
Copy link
Contributor Author

oh i think i see. hold on

@baconpaul
Copy link
Contributor Author

oh no i don't. now I'm in QT land. Ugh. I don't see a place to put it

Anyway, the ifs are correct; i just don't know how to add a settings panel to set the flag to true or false. I'll leave this here for now.

@abique
Copy link
Contributor

abique commented Sep 28, 2022

I've implemented the feature the way I wanted.
There's now a tweak dialog where we can add more settings in the future.

@abique abique closed this Oct 13, 2022
@baconpaul baconpaul deleted the zero-test branch October 13, 2022 15:28
@baconpaul
Copy link
Contributor Author

Awesome thanks @abique !

Between this and the validator changes we can test this well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants