-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FontAwesome 5 (free) and jQgrid compatibility issues #412
Comments
The structure of FontAwesome 5 and the CSS classes, which need be used, are heavy changed between FontAwesome 4 and FontAwesome 5. For example, one changed one base common class In general, free jqGrid allows to create custom |
@OlegKi sounds good no rush I will take a look on my time off and see what I can do to help. Thanks |
I used jqGrid quite extensively in an application I wrote, upgraded to bootstrap 4 and then font-awesome 5 followed. Instead of going backwards with the upgrade, I went ahead and tweaked jqGrid to work for me until Olek officially upgrades it. This isn't perfect and I only tweaked the main jqGrid plug-in - I didn't touch treeview at all since I don't use it. But, hopefully this will help someone for now. On a side note, thanks Olek - your additions to this plug-in have been awesome and your guides and tips on StackOverflow have been extremely helpful. I ended up writing some helper classes in C# for my application to go along with the grid and am eventually going to write up documentation about it...someday - but like you, other projects seem to come first. This is for the SVG version of font-awesome 5. What I did was added an icon set to the code and added the svg css code to the project as well. Every line that I added or edited has a notation on it so you can see exactly what I did. I am sure there are better ways of doing it, but I needed to get it done quick and this will work as a stop-gap until the real enhancement is made. |
@Djuwal Thank you very much for your post! I think that the information could be helpful for other developers, which uses free jqGrid. |
@reypm I didn't say it above, but to use it, be sure to change your iconSet to 'fontAwesomeSVG' and that you use the svg version of FontAwesome |
Thanks to Djuwal (https://github.com/Djuwal) for preparing the first of version of the changes, which are the origing of the commit. See [the comment](#412 (comment)) for more details. To use Font Awesome 5 one needs to use the option `iconSet: "fontAwesomeSVG"` instead of `iconSet: "fontAwesome"` and to include of cause JS file of Font Awesome 5. It could be for example `https://use.fontawesome.com/releases/v5.0.13/js/all.js` or altervatively `https://use.fontawesome.com/releases/v5.0.13/js/solid.js` and `https://use.fontawesome.com/releases/v5.0.13/js/fontawesome.js`.
I posted the first version of changes to GitHub (see here), made based on the suggestions from Djuwal. It's sure not a final code. Any bug reports or suggestions are welcome. |
FontAwesome 5 has been released in two flavors: free and pro (paid version). It looks cleaner and nicer than previous 4.x version :)
I was trying to use this version with jQgrid and it does not work properly. See jsFiddle using JS version (SVG) here and using CSS version here.
Is there any chance to get this working soon? If it's not so hard I can help I just need some guidance.
The text was updated successfully, but these errors were encountered: